Skip to content

Add pypi python 3.13 build to the pipeline #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Add pypi python 3.13 build to the pipeline #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8a7ed2
Add pypi python 3.13 build to the pipeline
phoebusm Nov 25, 2024
51c70cf
Update grpcio for protobuf version
phoebusm Dec 19, 2024
44bf9c9
Upgrade grpc pin
phoebusm Dec 20, 2024
c027325
update pin
phoebusm Dec 20, 2024
fbccd5a
Update requirement
phoebusm Dec 20, 2024
d1880f3
Update how to select cp313
phoebusm Dec 20, 2024
4e9bbec
Add missing version
phoebusm Dec 24, 2024
130c96c
Remove py312 related changes
phoebusm Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python3: ${{fromJson(vars.LINUX_PYTHON_VERSIONS || '[7, 8, 9, 10, 11, 12]')}}
python3: ${{fromJson(vars.LINUX_PYTHON_VERSIONS || '[7, 8, 9, 10, 11, 12, 13]')}}
include:
- python_deps_ids: [""]
matrix_override: ${{fromJson(needs.common_config.outputs.linux_matrix)}}
Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[7, 8, 9, 10, 11, 12]')}}
python3: ${{fromJson(vars.WINDOWS_PYTHON_VERSIONS || '[7, 8, 9, 10, 11, 12, 13]')}}
name: 3.${{matrix.python3}} Windows
uses: ./.github/workflows/build_steps.yml
secrets: inherit
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/build_steps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,13 @@ jobs:

- name: Select Python (Linux)
if: matrix.os == 'linux'
run: echo /opt/python/${{env.python_impl_name}}*/bin >> $GITHUB_PATH
run: |
#there are cp313 and cp313t
Copy link
Collaborator

@G-D-Petrov G-D-Petrov Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what us the difference between the two?

Copy link
Collaborator Author

@phoebusm phoebusm Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp313 with t is the experimental free threading version

if [[ "${{env.python_impl_name}}" == "cp313" ]]; then
echo /opt/python/cp313-cp313/bin >> $GITHUB_PATH;
else
echo /opt/python/${{env.python_impl_name}}*/bin >> $GITHUB_PATH;
fi

- name: Select Python (Windows)
if: matrix.os == 'windows'
Expand Down
6 changes: 5 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _log_and_run(*cmd, **kwargs):

class CompileProto(Command):
# When adding new protobuf versions, also update: setup.cfg, python/arcticdb/__init__.py
_PROTOBUF_TO_GRPC_VERSION = {"3": "<1.31", "4": ">=1.49", "5": ">=1.64"}
_PROTOBUF_TO_GRPC_VERSION = {"3": "<1.31", "4": ">=1.49", "5": ">=1.68.1"}

description = '"protoc" generate code _pb2.py from .proto files'
user_options = [
Expand Down Expand Up @@ -74,6 +74,10 @@ def run(self):
# Not compatible with Python<=3.7 as
# GRPCIO >= 1.64.0 is not available on Python<=3.7 https://pypi.org/project/grpcio-tools/1.64.0/#files
print(f"Python protobuf {proto_ver} does not run on Python {python}. Skipping...")
elif not ARCTICDB_USING_CONDA and python >= (3, 13) and proto_ver < "5":
# Not compatible with protobuf<5.26.1 as
# Python 3.13 requires GRPCIO >= 1.66.2, which requires protobuf >=5.26.1 https://github.com/grpc/grpc/blob/6fa8043bf9befb070b846993b59a3348248e6566/requirements.txt#L4
print(f"Python protobuf {proto_ver} does not run on Python {python}. Skipping...")
else:
self._compile_one_version(proto_ver, os.path.join(output_dir, proto_ver))

Expand Down
Loading