Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions ClaudeCodeSharpSDK.Tests/Unit/ClaudeExecTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ public class ClaudeExecTests
private const string DescriptionPropertyName = "Description";
private const string DescriptionPropertyNameCamel = "description";
private const string DisallowedToolsFlag = "--disallowed-tools";
private const string EffortFlag = "--effort";
private const string EffortHighValue = "high";
private const string EffortLowValue = "low";
private const string EffortMaxValue = "max";
private const string EffortMediumValue = "medium";
private const string ExampleBaseUrl = "https://example.invalid";
private const string FeatureABeta = "feature-a";
private const string FeatureBBeta = "feature-b";
Expand All @@ -41,6 +46,7 @@ public class ClaudeExecTests
private const string McpConfigPath = "/tmp/mcp.json";
private const string McpConfigTwo = """{"name":"two","command":"uvx","args":["c","d"]}""";
private const string ModelFlag = "--model";
private const string NameFlag = "--name";
private const string OutputFormatFlag = "--output-format";
private const string OutputSchemaMessageFragment = "ReplayUserMessages";
private const string PerTurnHookValue = "per-turn-hook";
Expand All @@ -59,6 +65,7 @@ public class ClaudeExecTests
private const string ResumeSessionId = "session-1";
private const string ReviewerAgentKey = "reviewer";
private const string ReviewerPrompt = "Review code changes";
private const string SessionDisplayName = "my-session";
private const string SettingSourcesFlag = "--setting-sources";
private const string SettingsFlag = "--settings";
private const string StreamJsonOutputFormat = "stream-json";
Expand Down Expand Up @@ -206,6 +213,64 @@ public async Task BuildCommandArgs_WithReservedAdditionalCliFlag_Throws()
await Assert.That(exception!.Message).Contains(ReservedOutputFormatFlag);
}

[Test]
[Arguments(EffortLevel.Low, EffortLowValue)]
[Arguments(EffortLevel.Medium, EffortMediumValue)]
[Arguments(EffortLevel.High, EffortHighValue)]
[Arguments(EffortLevel.Max, EffortMaxValue)]
public async Task BuildCommandArgs_WithEffort_MapsToCliValue(EffortLevel effort, string expectedCliValue)
{
var exec = new ClaudeExec(executablePath: TestConstants.ClaudeExecutablePath);

var commandArgs = exec.BuildCommandArgs(new ClaudeExecArgs
{
Input = SummarizeInput,
Effort = effort,
});

await Assert.That(GetRequiredFlagValue(commandArgs, EffortFlag)).IsEqualTo(expectedCliValue);
}

[Test]
public async Task BuildCommandArgs_WithoutEffort_OmitsEffortFlag()
{
var exec = new ClaudeExec(executablePath: TestConstants.ClaudeExecutablePath);

var commandArgs = exec.BuildCommandArgs(new ClaudeExecArgs
{
Input = SummarizeInput,
});

await Assert.That(commandArgs.Contains(EffortFlag)).IsFalse();
}

[Test]
public async Task BuildCommandArgs_WithName_MapsToCliFlag()
{
var exec = new ClaudeExec(executablePath: TestConstants.ClaudeExecutablePath);

var commandArgs = exec.BuildCommandArgs(new ClaudeExecArgs
{
Input = SummarizeInput,
Name = SessionDisplayName,
});

await Assert.That(GetRequiredFlagValue(commandArgs, NameFlag)).IsEqualTo(SessionDisplayName);
}

[Test]
public async Task BuildCommandArgs_WithoutName_OmitsNameFlag()
{
var exec = new ClaudeExec(executablePath: TestConstants.ClaudeExecutablePath);

var commandArgs = exec.BuildCommandArgs(new ClaudeExecArgs
{
Input = SummarizeInput,
});

await Assert.That(commandArgs.Contains(NameFlag)).IsFalse();
}

private static JsonObject CreateBaseSettings()
{
return new JsonObject
Expand Down
2 changes: 2 additions & 0 deletions ClaudeCodeSharpSDK/Client/ClaudeThread.cs
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,10 @@ private async IAsyncEnumerable<ThreadEvent> RunStreamedInternalAsync(
BaseUrl = _options.BaseUrl,
ApiKey = _options.ApiKey,
Model = _threadOptions.Model,
Name = _threadOptions.Name,
Agent = _threadOptions.Agent,
FallbackModel = _threadOptions.FallbackModel,
Effort = _threadOptions.Effort,
WorkingDirectory = _threadOptions.WorkingDirectory,
PermissionMode = _threadOptions.PermissionMode,
DangerouslySkipPermissions = _threadOptions.DangerouslySkipPermissions,
Expand Down
12 changes: 12 additions & 0 deletions ClaudeCodeSharpSDK/Client/ThreadOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ public enum PermissionMode
Plan,
}

public enum EffortLevel
{
Low,
Medium,
High,
Max,
}

public enum SettingSource
{
User,
Expand All @@ -25,10 +33,14 @@ public sealed record ThreadOptions
{
public string? Model { get; init; }

public string? Name { get; init; }

public string? Agent { get; init; }

public string? FallbackModel { get; init; }

public EffortLevel? Effort { get; init; }

public string? WorkingDirectory { get; init; }

public PermissionMode? PermissionMode { get; init; }
Expand Down
14 changes: 14 additions & 0 deletions ClaudeCodeSharpSDK/Execution/ClaudeExec.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ public sealed class ClaudeExec
private const string IncludePartialMessagesFlag = "--include-partial-messages";
private const string ReplayUserMessagesFlag = "--replay-user-messages";
private const string ModelFlag = "--model";
private const string NameFlag = "--name";
private const string AgentFlag = "--agent";
private const string FallbackModelFlag = "--fallback-model";
private const string EffortFlag = "--effort";
private const string PermissionModeFlag = "--permission-mode";
private const string DangerouslySkipPermissionsFlag = "--dangerously-skip-permissions";
private const string AllowDangerouslySkipPermissionsFlag = "--allow-dangerously-skip-permissions";
Expand Down Expand Up @@ -158,6 +160,12 @@ internal IReadOnlyList<string> BuildCommandArgs(ClaudeExecArgs args)
commandArgs.Add(args.Model);
}

if (!string.IsNullOrWhiteSpace(args.Name))
{
commandArgs.Add(NameFlag);
commandArgs.Add(args.Name);
}

if (!string.IsNullOrWhiteSpace(args.Agent))
{
commandArgs.Add(AgentFlag);
Expand All @@ -170,6 +178,12 @@ internal IReadOnlyList<string> BuildCommandArgs(ClaudeExecArgs args)
commandArgs.Add(args.FallbackModel);
}

if (args.Effort.HasValue)
{
commandArgs.Add(EffortFlag);
commandArgs.Add(args.Effort.Value.ToCliValue());
}

if (args.PermissionMode.HasValue)
{
commandArgs.Add(PermissionModeFlag);
Expand Down
4 changes: 4 additions & 0 deletions ClaudeCodeSharpSDK/Execution/ClaudeExecArgs.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,14 @@ public sealed record ClaudeExecArgs

public string? Model { get; init; }

public string? Name { get; init; }

public string? Agent { get; init; }

public string? FallbackModel { get; init; }

public EffortLevel? Effort { get; init; }

public string? WorkingDirectory { get; init; }

public PermissionMode? PermissionMode { get; init; }
Expand Down
20 changes: 20 additions & 0 deletions ClaudeCodeSharpSDK/Internal/ClaudeCliValueExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ private static class PermissionModeValues
public const string Plan = "plan";
}

private static class EffortLevelValues
{
public const string Low = "low";
public const string Medium = "medium";
public const string High = "high";
public const string Max = "max";
}

private static class SettingSourceValues
{
public const string User = "user";
Expand All @@ -35,6 +43,18 @@ public static string ToCliValue(this PermissionMode permissionMode)
};
}

public static string ToCliValue(this EffortLevel effortLevel)
{
return effortLevel switch
{
EffortLevel.Low => EffortLevelValues.Low,
EffortLevel.Medium => EffortLevelValues.Medium,
EffortLevel.High => EffortLevelValues.High,
EffortLevel.Max => EffortLevelValues.Max,
_ => throw new ArgumentOutOfRangeException(nameof(effortLevel), effortLevel, null),
};
}

public static string ToCliValue(this SettingSource settingSource)
{
return settingSource switch
Expand Down
2 changes: 1 addition & 1 deletion global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "10.0.103",
"version": "10.0.102",
"rollForward": "latestFeature"
},
"test": {
Expand Down