Skip to content

Conversation

@KSemenenko
Copy link
Member

Summary

  • ensure the CI pack steps pass the macOS native binary explicitly and log what is being packed
  • harden the package validation to inspect every produced nupkg and fail if none contain the native library
  • resolve the mac native binary paths from the project directory so local and CI builds locate the artifact reliably

Testing

  • not run (dotnet CLI not available in container)

https://chatgpt.com/codex/tasks/task_e_68e229d761248326b7098a2b8b83fdc3

Copilot AI review requested due to automatic review settings October 5, 2025 08:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes macOS native packaging in CI by improving path resolution and validation logic. The changes ensure that the macOS native binary is properly located and included in packages during CI builds.

  • Improved path resolution using MSBuild functions to locate native binaries reliably across different environments
  • Enhanced CI logging to show which native binary is being packed
  • Hardened package validation to inspect all produced packages and fail if any lack the native library

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/MLXSharp/MLXSharp.csproj Updated path resolution to use MSBuild functions for reliable cross-platform path handling
.github/workflows/ci.yml Enhanced CI pack steps with explicit logging and improved package validation logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@KSemenenko KSemenenko merged commit 821b67c into main Oct 5, 2025
1 of 2 checks passed
@KSemenenko KSemenenko deleted the codex/fix-msbuild-project-specification-error branch October 5, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants