Refactored Orleans.Identity. Removed unnecessary parts, leaved grain … #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…authorization and authentication. Implemented extension method for grain to get user claims from request context
KSemenenko
reviewed
Jul 30, 2025
ManagedCode.Orleans.Identity.Client/Middlewares/SignalRAuthorizationFilter.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Client/Middlewares/SignalRAuthorizationFilter.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Client/Middlewares/SignalRAuthorizationFilter.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Client/Middlewares/OrleansContextMiddleware.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Core/Extensions/GrainExtensions.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Core/Extensions/GrainExtensions.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Server/GrainCallFilter/GrainAuthorizationIncomingFilter.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Orleans.Identity library to simplify its architecture and focus on JWT-based authorization for ASP.NET Core applications. The main changes include removing session and token management components while retaining grain-level authorization capabilities.
- Removed session grain and token grain functionality to simplify the system
- Implemented JWT authentication and authorization pipeline for ASP.NET Core
- Added extension methods for grains to access current user claims from request context
Reviewed Changes
Copilot reviewed 65 out of 65 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated documentation to reflect simplified JWT-based architecture with usage examples |
| ManagedCode.Orleans.Identity.Tests/ | Removed legacy token and session tests, added new JWT controller and SignalR tests |
| ManagedCode.Orleans.Identity.Server/GrainCallFilter/ | Updated authorization filter to use claims from request context instead of session grains |
| ManagedCode.Orleans.Identity.Core/Extensions/ | Added grain extension methods to get current user claims |
| ManagedCode.Orleans.Identity.Client/Middlewares/ | Replaced session-based middleware with JWT claim propagation middleware |
ManagedCode.Orleans.Identity.Tests/TestApp/Controllers/UserController.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Tests/TestApp/Controllers/UserController.cs
Outdated
Show resolved
Hide resolved
ManagedCode.Orleans.Identity.Server/GrainCallFilter/GrainAuthorizationIncomingFilter.cs
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…authorization and authentication. Implemented extension method for grain to get user claims from request context