Phase 2: Logging, middleware, health checks, and setup_app()#5
Merged
Conversation
- logging/config.py: LogConfig dataclass - logging/masking.py: Recursive sensitive data masking (depth-limited, non-mutating) - logging/structured_logger.py: StructuredLogger + correlation_id contextvar - middleware/correlation_id.py: UUID per request, X-Correlation-ID header - middleware/request_logging.py: method/path/status/duration logging - middleware/security_headers.py: HSTS, X-Frame-Options, etc. - health/endpoints.py: GET /health + GET /health/detailed - settings/config.py: FastStackConfig dataclass (toggles for all features) - setup.py: setup_app() one-call registration with per-feature toggles 31 new tests (100 total) covering: - Sensitive data masking (nested dicts, depth limit, case-insensitive) - Correlation ID generation and propagation - Security headers presence and non-override behavior - Health endpoints - setup_app() with all defaults and with features individually disabled - CORS enable/disable Part of Phase 2 in #1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test coverage
31 new tests (100 total):
How to test
make check # lint + typecheck + 100 tests passOr check CI on this PR — all 4 status checks should be green.
Part of
Phase 2 in #1
🤖 Generated with Claude Code