Skip to content

Misc fixes#54

Merged
ghaskins merged 4 commits intomanetu:mainfrom
ghaskins:misc
Jan 27, 2026
Merged

Misc fixes#54
ghaskins merged 4 commits intomanetu:mainfrom
ghaskins:misc

Conversation

@ghaskins
Copy link
Copy Markdown
Contributor

See commit messages for details

Allow users to use []string (in addition to []interface{}) for array
fields like mroles, mgroups, and scopes when constructing PORC maps
directly in Go. This provides a more idiomatic Go developer experience.

Signed-off-by: Greg Haskins <greg@manetu.com>
- Always expand the porc field from JSON string to object for readability
- Add --pretty-log global flag for indented multi-line JSON output
- Add AccessLogOptions struct and NewIoWriterFactoryWithOptions constructor
- Add comprehensive tests for porc expansion and pretty-print

Signed-off-by: Greg Haskins <greg@manetu.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 77.61194% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/core/accesslog/stdout.go 70.37% 5 Missing and 3 partials ⚠️
cmd/mpe/main.go 0.00% 5 Missing ⚠️
pkg/core/config/config.go 33.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Comment thread pkg/core/config/config.go
muralisrini
muralisrini previously approved these changes Jan 27, 2026
Copy link
Copy Markdown
Contributor

@muralisrini muralisrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Missing config file is expected behavior - users may rely solely on
environment variables or defaults. Only log warnings for actual errors
like malformed YAML.

Signed-off-by: Greg Haskins <greg@manetu.com>
Create new Guides section in documentation:
- reading-access-records.md: comprehensive guide to interpreting
  AccessRecord output including pretty-log usage, phase explanations,
  and debugging workflows
- testing-policies.md: full testing guide covering decision, mapper,
  and envoy commands with common patterns and best practices

Simplify quick-start/testing-policies.md to focus on basics,
linking to the comprehensive guide for deeper content.

Signed-off-by: Greg Haskins <greg@manetu.com>
@ghaskins ghaskins merged commit c409682 into manetu:main Jan 27, 2026
16 checks passed
@ghaskins ghaskins deleted the misc branch January 27, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants