There is no explicit way to revoke an access token when the user logs out #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, @manfredsteyer can you have a look at this, please. |
Collaborator
jeroenheijmans
left a comment
jeroenheijmans
left a comment
There was a problem hiding this comment.
I haven't fully reviewed or tested this yet (I'm unsure how revokation should work according to the standard). Either way:
Thanks for the PR! Hopefully Manfred will have time to check it out.
Small thing: please don't use console.log but this.logger.log instead, as it allows people to intercept or suppress it.
Contributor
Author
|
Hi @manfredsteyer I have made changes as suggested by you. Please Verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a pull request for issue - #763 (comment)