DBC: add legacy-name breadcrumbs to renamed struct fields#429
Merged
Conversation
Post-#428 review follow-up (antz): the build-exact rename made some members read generically (e.g. SpellName -> Name_lang), so a `git grep` for the old mangos field name no longer found the field. Append a `(was <legacyName>)` breadcrumb to each renamed active member's comment so the old name stays greppable and the field remains easy to hunt down a year from now. Comment-only, no code change: 117 fields across 30 structs, every one a pure trailing-comment append (verified: 0 declaration/type/name edits). The legacy names are generated from the campaign's authoritative rename maps (reconciliation.json + spell-rename-map.json) and every one was validated as a real pre-#428 active member. Pure case reformats (findable by case-insensitive grep) are intentionally skipped. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #428. The build-exact rename in #428 aligned some
DBCStructure.hmembers to their client-schema names, which occasionally read more generically
than the old mangos names (e.g.
SpellName→Name_lang,Rank→NameSubtext_lang).As @Antz noted in review, that makes a field harder to hunt down a year later —
grepping the familiar old name no longer finds it.
This appends a
(was <legacyName>)breadcrumb to each renamed field's comment, sothe old name stays greppable. Comment-only — no code change.
Example