update ruby version, sqlite version, and fix tests#10
Merged
jantmanAtCox merged 3 commits intomanheim:masterfrom Jul 29, 2025
Merged
update ruby version, sqlite version, and fix tests#10jantmanAtCox merged 3 commits intomanheim:masterfrom
jantmanAtCox merged 3 commits intomanheim:masterfrom
Conversation
jantmanAtCox
requested changes
Jul 24, 2025
Contributor
jantmanAtCox
left a comment
jantmanAtCox
left a comment
There was a problem hiding this comment.
@jeremiahlukus Can you please also add a spec.required_ruby_version to this spec file, set to... whatever you think is appropriate? I'm guessing probably something like >= 3.0.0 (but not positive, I haven't written any ruby in years and years). I think that will help ensure that existing users still on old ruby versions don't pull in a new and incompatible version of the package.
Also, I think you probably need to make the same updates in the vinbot-jruby.gemspec file for the jruby version? Though I've never really done anything with jruby, and don't know what the appropriate version is or even how to build that variant of the gem...
Contributor
Author
|
Done, also fixed jruby issues and added a simple testing workflow. |
jantmanAtCox
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested this in a app that heavily uses this, there are no breaking changes other than the sqlite3 requirement.