Reduce gridlink memory footprint #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gridlink has a rather large memory footprint after the min_sep_opt changes. One way to reduce this is by slimming down the
cell_pairstrut to hold only pair info, and not cell info (#185). But for autocorrelations, there's another factor-of-2 savings possible from the fact that we're presently allocating enough memory to double-count every cell pair, even though we only singly count them. This PR implements that memory saving for autocorrelations.@manodeep: I think it should be obvious pretty quickly if I messed up the
max_num_cell_pairscalculation, since we have an explicitnum_cell_pairs < max_num_cell_pairscheck. Let's see what Travis says (local tests are passing).Also feel free to tack on the
cell_pairslimming optimizations to this PR.