Fix parsing error when periodic=False and boxsize not given in the theory module #257
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lgarrison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-09-10 22:42:49 UTC |
manodeep
reviewed
Sep 10, 2021
Owner
manodeep
left a comment
manodeep
left a comment
There was a problem hiding this comment.
Thanks for the quick fix - everything looks good except for that one change in vpf.py. Might be better to keep the periodic and boxsize=None check separate from the kwargs - that will be easier to parse for the reader and be consistent with the remainder of the counters
Owner
|
Unsure why the astropy bots are complaining - the milestone is set and a changelog entry is present. |
manodeep
approved these changes
Sep 11, 2021
Owner
|
@lgarrison This is ready to merge right? |
Collaborator
Author
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #256, don't pass a boxsize of
Noneto the C extensions.