Initial version of Cgit integration for mantis/source-integration.#3
Merged
Merged
Conversation
Contributor
|
Personally, I'm not found of the negative conditional to handle the test instance, although I'm not sure if there's a better way either. However, if the test case is going to be left in, there should be some sort of documentation, either in a code comment or in a separate file, that explains how to use the test cases, what the tests cover, and how to determine if they are successful or not. Otherwise, although I don't have a Cgit instance that I can test it against with my own repositories, the overall code looks really good. If you can clear up the few comments I had, I'll gladly pull it into the main project. Thanks! |
amyreese
added a commit
that referenced
this pull request
Jun 8, 2011
Initial version of Cgit integration for mantis/source-integration.
Contributor
|
Looks good now, thanks for the contribution. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope you and possibly others like it!