chore: adding tests for multiple structs defined in the same type#44
Merged
chore: adding tests for multiple structs defined in the same type#44
Conversation
Collaborator
|
It's a choice; there is no right or wrong approach here. |
Owner
Author
good point, right now it's not getting processed, do you think it's a good idea that this linter also "handle" this scenario? |
Collaborator
|
I think grouping type is an explicit way to say you want to group types first, so suggesting to split the group does not follow the expected style. Grouping types is a too "squared" style for me, but in this context, grouping types is superior to order methods and functions. |
Owner
Author
|
actually I updated the tests to properly test a scenario, and the linter is handling it. |
Owner
Author
|
@ldez shall we merge this PR (to keep track of the current behaviour), and leave the linter as it is? |
ldez
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a test to cover the case:
the linter is not checking for constructors or methods for this type.
What do you guys @ldez, @alexandear & @ccoVeille think?