-
Notifications
You must be signed in to change notification settings - Fork 10
Add support for CRISPR homology-directed repair (WIP) #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Minimal working example with standard Cas9 and 20bp guide - Guide is provided as an primer - TODO: add tests for edge cases
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 93.61% 93.68% +0.06%
==========================================
Files 7 7
Lines 1065 1108 +43
==========================================
+ Hits 997 1038 +41
- Misses 68 70 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @dgruano, I have added a few basic tests and refactored a bit. The most important change is that now you can add more than one guide RNA to be passed. I can add for the tests cases you mentioned, but I have some questions about specific cases and what should happen to them: Ex1 / Ex2: Not sure what should happen here. Here the homology region would clearly be too short, perhaps if the cut falls on top the homology region, it should only be allowed if the remaining homology arm is >= minimal_homology. EX4: This would be a no for me, I would say. EX5: I did not see the difference between this and EX4 |
|
I will merge this, since it has some minimal functionality, but I keep the issue open to add the tests. |
|
Hi @manulera , great! For Ex1/Ex2, I agree. The cloning strategy needs to have minimal homology in both sides of the cut, so I would add that limitation. Ex4 should not work as the homology region does not span over both sides of the cut. Ex5 is a special case because the right side of the insert is homologous to two different sections of the template. Here is a more clear representation: In this example, using HR2 homology regions, the cut happens between them and can be repaired. PS: Great addition to allow for multiple guides! Looking forward to test it. |
|
This is now added in the hosted version, thanks @dgruano |
Hi @manulera !
Following our discussion on #102 , I implemented some basic functionality to use CRISPR. It follows the same logic as standard Homologous Recombination, but checks that the Cas9 cut occurs within the homology region.
I added a file with an example cloning strategy with template, insert and guide to test CRISPR in the app,
crispr_test.json.We just need to find a nice way to add tests for edge cases. I did quick and dirty tests in the
crispr.ipynbnotebook, but I have not found a way to properly implement them just yet. This is because the tests use a hypothetical Cas9 enzyme with a 5 bp guide (makes it easy to design the sequences for the tests), but the current version of the endpoint uses a hardcoded standard Cas9 with 20 bp guide. We could:Let me know your thoughts.
Cheers!