Skip to content

feat(create-anywidget): Simplify CSS selectors #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2024
Merged

feat(create-anywidget): Simplify CSS selectors #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-seas-drive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"create-anywidget": patch
---

Simplify default CSS class names
96 changes: 46 additions & 50 deletions packages/create-anywidget/__tests__/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,11 @@ import "./widget.css";
const render = createRender(() => {
const [value, setValue] = useModelState("value");
return (
<button
className="ipyfoo-counter-button"
onClick={() => setValue(value + 1)}
>
count is {value}
</button>
<div className="ipyfoo">
<button onClick={() => setValue(value + 1)}>
count is {value}
</button>
</div>
);
});

Expand All @@ -176,7 +175,7 @@ export default { render };
"path": "js/widget.jsx",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -196,7 +195,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -372,12 +371,11 @@ import "./widget.css";
const render = createRender(() => {
const [value, setValue] = useModelState<number>("value");
return (
<button
className="ipyfoo-counter-button"
onClick={() => setValue(value + 1)}
>
count is {value}
</button>
<div className="ipyfoo">
<button onClick={() => setValue(value + 1)}>
count is {value}
</button>
</div>
);
});

Expand All @@ -386,7 +384,7 @@ export default { render };
"path": "js/widget.tsx",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -406,7 +404,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -598,7 +596,6 @@ class Widget(anywidget.AnyWidget):

function render({ model, el }) {
let btn = document.createElement("button");
btn.classList.add("ipyfoo-counter-button");
btn.innerHTML = \`count is \${model.get("value")}\`;
btn.addEventListener("click", () => {
model.set("value", model.get("value") + 1);
Expand All @@ -607,6 +604,7 @@ function render({ model, el }) {
model.on("change:value", () => {
btn.innerHTML = \`count is \${model.get("value")}\`;
});
el.classList.add("ipyfoo");
el.appendChild(btn);
}

Expand All @@ -615,7 +613,7 @@ export default { render };
"path": "js/widget.js",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -635,7 +633,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -794,7 +792,6 @@ class Widget(anywidget.AnyWidget):
/** @type {import("npm:@anywidget/types").Render<Model>} */
function render({ model, el }) {
let btn = document.createElement("button");
btn.classList.add("ipyfoo-counter-button");
btn.innerHTML = \`count is \${model.get("value")}\`;
btn.addEventListener("click", () => {
model.set("value", model.get("value") + 1);
Expand All @@ -804,6 +801,7 @@ function render({ model, el }) {
confetti();
btn.innerHTML = \`count is \${model.get("value")}\`;
});
el.classList.add("ipyfoo");
el.appendChild(btn);
}

Expand All @@ -812,7 +810,7 @@ export default { render };
"path": "src/ipyfoo/static/widget.js",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -832,7 +830,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -1007,7 +1005,6 @@ interface WidgetModel {

function render({ model, el }: RenderContext<WidgetModel>) {
let btn = document.createElement("button");
btn.classList.add("ipyfoo-counter-button");
btn.innerHTML = \`count is \${model.get("value")}\`;
btn.addEventListener("click", () => {
model.set("value", model.get("value") + 1);
Expand All @@ -1016,6 +1013,7 @@ function render({ model, el }: RenderContext<WidgetModel>) {
model.on("change:value", () => {
btn.innerHTML = \`count is \${model.get("value")}\`;
});
el.classList.add("ipyfoo");
el.appendChild(btn);
}

Expand All @@ -1024,7 +1022,7 @@ export default { render };
"path": "js/widget.ts",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -1044,7 +1042,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -1245,12 +1243,11 @@ import "./widget.css";
const render = createRender(() => {
const [value, setValue] = useModelState("value");
return (
<button
className="ipyfoo-counter-button"
onClick={() => setValue(value + 1)}
>
count is {value}
</button>
<div className="ipyfoo">
<button onClick={() => setValue(value + 1)}>
count is {value}
</button>
</div>
);
});

Expand All @@ -1259,7 +1256,7 @@ export default { render };
"path": "js/widget.jsx",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -1279,7 +1276,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -1456,12 +1453,11 @@ import "./widget.css";
const render = createRender(() => {
const [value, setValue] = useModelState<number>("value");
return (
<button
className="ipyfoo-counter-button"
onClick={() => setValue(value + 1)}
>
count is {value}
</button>
<div className="ipyfoo">
<button onClick={() => setValue(value + 1)}>
count is {value}
</button>
</div>
);
});

Expand All @@ -1470,7 +1466,7 @@ export default { render };
"path": "js/widget.tsx",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -1490,7 +1486,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -1684,7 +1680,6 @@ class Widget(anywidget.AnyWidget):

function render({ model, el }) {
let btn = document.createElement("button");
btn.classList.add("ipyfoo-counter-button");
btn.innerHTML = \`count is \${model.get("value")}\`;
btn.addEventListener("click", () => {
model.set("value", model.get("value") + 1);
Expand All @@ -1693,6 +1688,7 @@ function render({ model, el }) {
model.on("change:value", () => {
btn.innerHTML = \`count is \${model.get("value")}\`;
});
el.classList.add("ipyfoo");
el.appendChild(btn);
}

Expand All @@ -1701,7 +1697,7 @@ export default { render };
"path": "js/widget.js",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -1721,7 +1717,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -1880,7 +1876,6 @@ class Widget(anywidget.AnyWidget):
/** @type {import("npm:@anywidget/types").Render<Model>} */
function render({ model, el }) {
let btn = document.createElement("button");
btn.classList.add("ipyfoo-counter-button");
btn.innerHTML = \`count is \${model.get("value")}\`;
btn.addEventListener("click", () => {
model.set("value", model.get("value") + 1);
Expand All @@ -1890,6 +1885,7 @@ function render({ model, el }) {
confetti();
btn.innerHTML = \`count is \${model.get("value")}\`;
});
el.classList.add("ipyfoo");
el.appendChild(btn);
}

Expand All @@ -1898,7 +1894,7 @@ export default { render };
"path": "src/ipyfoo/static/widget.js",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -1918,7 +1914,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down Expand Up @@ -2094,7 +2090,6 @@ interface WidgetModel {

function render({ model, el }: RenderContext<WidgetModel>) {
let btn = document.createElement("button");
btn.classList.add("ipyfoo-counter-button");
btn.innerHTML = \`count is \${model.get("value")}\`;
btn.addEventListener("click", () => {
model.set("value", model.get("value") + 1);
Expand All @@ -2103,6 +2098,7 @@ function render({ model, el }: RenderContext<WidgetModel>) {
model.on("change:value", () => {
btn.innerHTML = \`count is \${model.get("value")}\`;
});
el.classList.add("ipyfoo");
el.appendChild(btn);
}

Expand All @@ -2111,7 +2107,7 @@ export default { render };
"path": "js/widget.ts",
},
{
"content": ".ipyfoo-counter-button {
"content": ".ipyfoo button {
background: linear-gradient(
300deg,
#9933ff 33.26%,
Expand All @@ -2131,7 +2127,7 @@ export default { render };
transition: transform 0.25s ease-in-out;
}

.ipyfoo-counter-button:hover {
.ipyfoo button:hover {
transform: scale(1.05);
}
",
Expand Down
Loading