Skip to content
This repository was archived by the owner on Mar 16, 2026. It is now read-only.

Non-fatal exceptions reporting#512

Merged
friendoye merged 2 commits intomainfrom
nn/report-non-fatal-exceptions
Feb 17, 2021
Merged

Non-fatal exceptions reporting#512
friendoye merged 2 commits intomainfrom
nn/report-non-fatal-exceptions

Conversation

@friendoye
Copy link
Copy Markdown
Contributor

This PR:

  1. Adds support for reporting non-fatal exceptions via Telemetry SDK (in a similar way to iOS Telemetry SDK);
  2. Improve stackTrace information: stackTrace now keeps more information about original stack trace (more classes might be allowed for keeping in stack trace, exception message also added to stack trace);
  3. Fixes failed SchemaTest.

@friendoye friendoye marked this pull request as ready for review February 15, 2021 11:23
@tarigo tarigo self-requested a review February 15, 2021 17:17
Copy link
Copy Markdown
Contributor

@tarigo tarigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @friendoye!

@friendoye friendoye merged commit 4b2864d into main Feb 17, 2021
@friendoye friendoye deleted the nn/report-non-fatal-exceptions branch February 17, 2021 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants