Skip to content

ensure erroring tiles dont block map from firing load events #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mollymerp merged 2 commits into from
Mar 15, 2017
Merged

ensure erroring tiles dont block map from firing load events #4426

mollymerp merged 2 commits into from
Mar 15, 2017

Conversation

@mollymerp
Copy link
Contributor

@mollymerp mollymerp commented Mar 15, 2017 •
edited
Loading

fix #4425

the previousState argument for the _tileLoaded wasn't being bound here so the err wasn't being caught, and thus tiles that error out were preventing map, style and source from returning true from #loaded()

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@mollymerp mollymerp changed the title make sure previousState is bound to _tileLoaded ensure erroring tiles dont block map from firing load events Mar 15, 2017
anandthakker
anandthakker approved these changes Mar 15, 2017
View reviewed changes
Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@mollymerp mollymerp merged commit a7fc574 into master Mar 15, 2017
@mollymerp mollymerp deleted the fix-loaded branch March 15, 2017 18:49
andrewharvey pushed a commit to andrewharvey/mapbox-gl-js that referenced this pull request Mar 17, 2017
@mollymerp @andrewharvey
ensure erroring tiles dont block map from firing load events (mapbox#…
732f6aa 
…4426)

* make sure previousState is bound to _tileLoaded

* add a test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@anandthakker anandthakker anandthakker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

map.loaded() returns false if tiles error

2 participants

@mollymerp @anandthakker