TurfMeasurement#square #1019
Merged
TurfMeasurement#square #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langsmith
reviewed
May 1, 2019
osana
reviewed
May 2, 2019
| */ | ||
| public static BoundingBox square(@NonNull BoundingBox boundingBox) { | ||
| double horizontalDistance = distance( | ||
| Point.fromLngLat(boundingBox.west(), boundingBox.south()), |
Contributor
There was a problem hiding this comment.
you can just use boundingBox.southwest() instead of creating a point
|
|
||
| if (horizontalDistance >= verticalDistance) { | ||
| double verticalMidpoint = (boundingBox.south() + boundingBox.north()) / 2; | ||
| return BoundingBox.fromCoordinates( |
Contributor
There was a problem hiding this comment.
Use BoundingBox.fromLngLats instead of fromCoordinates
| ); | ||
| double verticalDistance = distance( | ||
| Point.fromLngLat(boundingBox.west(), boundingBox.south()), | ||
| Point.fromLngLat(boundingBox.west(), boundingBox.north()) |
Contributor
There was a problem hiding this comment.
you can just use boundingBox.northeast() instead of creating a point
Member
Author
There was a problem hiding this comment.
there is no northEast coordinate used
langsmith
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of https://turfjs.org/docs/#square