Skip to content

MapMatching: added ignore param #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RingerJK merged 2 commits into from
Apr 27, 2022
Merged

MapMatching: added ignore param #1424

RingerJK merged 2 commits into from
Apr 27, 2022

Conversation

@RingerJK
Copy link
Contributor

@RingerJK RingerJK commented Apr 27, 2022 •
edited
Loading

closes #1304

@RingerJK RingerJK requested a review from Guardiola31337 April 27, 2022 16:27
@RingerJK RingerJK self-assigned this Apr 27, 2022
@RingerJK RingerJK requested a review from a team as a code owner April 27, 2022 16:27
@RingerJK RingerJK force-pushed the kyv-mapmatchin-added-ignore- branch from 5813f4f to 0cb39ad Compare April 27, 2022 16:37
@codecov
Copy link

codecov bot commented Apr 27, 2022 •
edited
Loading

Codecov Report

Merging #1424 (c52d9c3) into main (d0862d9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1424      +/-   ##
============================================
+ Coverage     75.64%   75.68%   +0.04%     
  Complexity      897      897              
============================================
  Files           124      124              
  Lines          3904     3911       +7     
  Branches        606      607       +1     
============================================
+ Hits           2953     2960       +7     
  Misses          688      688              
  Partials        263      263
Impacted Files Coverage Δ
...ox/api/matching/v5/models/MapMatchingMatching.java 100.00% <ø> (ø)
.../com/mapbox/api/matching/v5/MapboxMapMatching.java 89.79% <100.00%> (+0.51%) ⬆️

@RingerJK RingerJK requested a review from Guardiola31337 April 27, 2022 16:47
Guardiola31337
Guardiola31337 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments 🚀

@Guardiola31337
Copy link
Contributor

Guardiola31337 commented Apr 27, 2022

Not sure if you want to clean up the commit history before merging though.

@RingerJK RingerJK merged commit b300f37 into main Apr 27, 2022
@RingerJK RingerJK deleted the kyv-mapmatchin-added-ignore- branch April 27, 2022 16:52
@RingerJK
Copy link
Contributor Author

RingerJK commented Apr 27, 2022

Not sure if you want to clean up the commit history before merging though.

squashed 👍

This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RingerJK RingerJK

Labels

Map Matching

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add ignore parameter to Map Matching API service

2 participants

@RingerJK @Guardiola31337