Skip to content

RouteOptions: added max_weight #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RingerJK merged 1 commit into from
May 17, 2022
Merged

RouteOptions: added max_weight #1439

RingerJK merged 1 commit into from
May 17, 2022

Conversation

@RingerJK
Copy link
Contributor

@RingerJK RingerJK commented May 17, 2022

No description provided.

@RingerJK RingerJK self-assigned this May 17, 2022
@RingerJK RingerJK force-pushed the kyv-route-options-max-weight branch from 17b57f0 to 727b46a Compare May 17, 2022 15:23
@RingerJK RingerJK marked this pull request as ready for review May 17, 2022 15:27
@RingerJK RingerJK requested a review from a team as a code owner May 17, 2022 15:27
@codecov
Copy link

codecov bot commented May 17, 2022 •
edited
Loading

Codecov Report

Merging #1439 (7dae0b1) into main (3da6e8a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7dae0b1 differs from pull request most recent head 0616b34. Consider uploading reports for the commit 0616b34 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1439      +/-   ##
============================================
+ Coverage     75.49%   75.51%   +0.01%     
  Complexity      874      874              
============================================
  Files           124      124              
  Lines          3889     3892       +3     
  Branches        577      577              
============================================
+ Hits           2936     2939       +3     
  Misses          690      690              
  Partials        263      263
Impacted Files Coverage Δ
.../mapbox/api/directions/v5/models/RouteOptions.java 85.31% <100.00%> (+0.08%) ⬆️
...com/mapbox/api/directions/v5/MapboxDirections.java 89.07% <100.00%> (+0.18%) ⬆️

@RingerJK RingerJK force-pushed the kyv-route-options-max-weight branch from 727b46a to 7dae0b1 Compare May 17, 2022 15:48
@RingerJK RingerJK force-pushed the kyv-route-options-max-weight branch from 7dae0b1 to 0616b34 Compare May 17, 2022 15:54
@RingerJK RingerJK requested a review from LukasPaczos May 17, 2022 15:54
LukasPaczos
LukasPaczos approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RingerJK RingerJK merged commit 644552f into main May 17, 2022
@RingerJK RingerJK deleted the kyv-route-options-max-weight branch May 17, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@RingerJK RingerJK

Labels

release blocker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RingerJK @LukasPaczos