mapbox/driving-traffic support added to the list of directions profil…#292
mapbox/driving-traffic support added to the list of directions profil…#292
Conversation
…es; checks added for maximum number of coordinates provided
zugaldia
left a comment
zugaldia
left a comment
There was a problem hiding this comment.
I think the traffic response is similar to the non-traffic response, still, and in case this changes in the future, how about adding a test like mentioned on #290 (comment)?
| } | ||
|
|
||
|
|
||
| if (profile != null && profile.equals(DirectionsCriteria.PROFILE_DRIVING_TRAFFIC) |
There was a problem hiding this comment.
@srabenja Considering that profile and coordinates are required parameters, how about we add a check before these two to raise an exception if either is null (or empty)?
|
@zugaldia I added the changes you mentioned |
|
@srabenja I see the fixture, but I see no tests using it? |
|
I have fixed a few documentation things, cleaned up the fixture, rewrote some exception messages to make it more clear what error occurred and lastly, added a few test. @zugaldia can you review this again? |
3 participants
…es, and checks added for maximum number of coordinates that can be provided, as discussed with @zugaldia