Skip to content

Added bearing query parameter #337

Merged
cammace merged 5 commits intomasterfrom
cam-add-bearing
Feb 20, 2017
Merged

Added bearing query parameter #337
cammace merged 5 commits intomasterfrom
cam-add-bearing

Conversation

@cammace
Copy link

@cammace cammace commented Feb 20, 2017

We were missing this parameter in our builder.

@mention-bot
Copy link

@cammace, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zugaldia, @ghoshkaj and @tobrun to be potential reviewers.

@cammace cammace added this to the v2.0.0 milestone Feb 20, 2017
@cammace cammace self-assigned this Feb 20, 2017
@cammace cammace requested a review from zugaldia February 20, 2017 21:49
Copy link
Member

@zugaldia zugaldia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on activity logging and we're 👍 .

client.enqueueCall(new Callback<DirectionsResponse>() {
@Override
public void onResponse(Call<DirectionsResponse> call, Response<DirectionsResponse> response) {
System.out.println(call.request().url().toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log.d is better here.

@cammace cammace merged commit 5ca8404 into master Feb 20, 2017
@cammace cammace deleted the cam-add-bearing branch February 20, 2017 22:25
@zugaldia zugaldia mentioned this pull request Feb 22, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 9, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 17, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants