Skip to content

Added infinity exception to if statement inside Position object #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cammace merged 3 commits into from
Apr 1, 2017
Merged

Added infinity exception to if statement inside Position object #416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb510ab
added infinity exception to if statement
Mar 27, 2017
ab44e57
reversed order
Mar 30, 2017
51408fa
add ( )
Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mapbox/libjava-core/src/main/java/com/mapbox/services/commons/models/Position.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ private Position(double longitude, double latitude, double altitude) {
this.latitude = latitude;
this.altitude = altitude;

if (latitude < -90 || latitude > 90) {
if (latitude != Double.POSITIVE_INFINITY && (latitude < -90 || latitude > 90)) {
// Checks the latitude value is within range or provide a warning otherwise
logger.warning(String.format(Constants.DEFAULT_LOCALE,
"Latitude value seems to be out of range (found: %f, expected: [-90, 90]). "
+ "Did you accidentally reverse the longitude/latitude order?",
latitude));
}

if (longitude < -180 || longitude > 180) {
if (longitude != Double.POSITIVE_INFINITY && (longitude < -180 || longitude > 180)) {
// Checks the longitude value is within range or provide a warning otherwise
logger.warning(String.format(Constants.DEFAULT_LOCALE,
"Longitude value seems to be out of range (found: %f, expected: [-180, 180]). "
Expand Down