Conversation
| @@ -219,7 +228,7 @@ private void sendEventsWrapped(Vector<Hashtable<String, Object>> events, Callbac | |||
| String url = getEventsEndpoint() + "/events/v2?access_token=" + getAccessToken(); | |||
|
|
|||
| // Extra debug in staging mode | |||
There was a problem hiding this comment.
This comment is now lying. This is an example of why I'm not a big fan of comments ![]()
|
|
||
| // Extra debug in staging mode | ||
| if (isStagingEnvironment()) { | ||
| if (isDebugLoggingEnabled()) { |
There was a problem hiding this comment.
@zugaldia
If we're going to go this way, we need to change
with MapboxTelemetry#setDebugLoggingEnabled(true) and deprecate/adapt
its getter and its setter
Another possibility is adding || isStagingEnvironment() and not break anything 😉
Right now, we're not logging when in staging mode if we don't set debugLoggingEnabled to true which is not desired because we're not preserving previous functionality.
There was a problem hiding this comment.
Good call, let's do || isStagingEnvironment() for now. Fixing up in a bit.
Guardiola31337
left a comment
There was a problem hiding this comment.
The best comment is a good name for a method or class.
or variable in this case 😛
👀 Code Smells 👉 Comments
This API lets us manually control the verbosity of HTTP requests.