Adding userAgent parameter to Isochrone request retrofit call URL

[langsmith]

Resolves #996 by adding a required /mapbox/ slug to the Isochrone API service's Retrofit request URL. Based on my demo app refactoring work in mapbox/mapbox-android-demo#1029, the #996 bug renders the wrapper unusable.

The API's docs

Totally fine if this is the wrong way to fix the bug. Figured I'd open something to get the conversation started.

[langsmith]

Actually, I'm now seeing how other navigation API wrappers in the repo, handle the user agent. Will adjust the isochrone support accordingly

[osana]

@langsmith Technically speaking this becomes a 5.0.0 release because the API changed and it is not backward compatible. I am surprised the tests did not catch this? I guess because a response was mocked. Did your sample code work?

Also, I think the way to fix this without making a major release would be to add the new method (not modify the existing one). One old one can be deprecated and we will remove it when 5.0.0 is done.

[langsmith]

I am surprised the tests did not catch this? I guess because a response was mocked. Did your sample code work?

Yea, sample code worked. I think we didn't catch this because I put the /mapbox/ slug in the Makefile isochrone fixture URLs (https://github.com/mapbox/mapbox-java/blob/master/Makefile#L199).

Also, I think the way to fix this without making a major release would be to add the new method (not modify the existing one). One old one can be deprecated and we will remove it when 5.0.0 is done.

Sounds 💯 . I've pushed and rebased this fix. Added a new getCall() method which has the user parameter. Also added needed deprecated annotations to the previous getCall() method.

[langsmith]

Going to test this work by using a Java services SNAPSHOT in the demo app isochrone refactor pr mapbox/mapbox-android-demo#1029