Skip to content

[example] Fix low level camera animation and basic globe example#1468

Merged
ank27 merged 2 commits intomainfrom
ak-fix-low-level-camera-example
Jun 30, 2022
Merged

[example] Fix low level camera animation and basic globe example#1468
ank27 merged 2 commits intomainfrom
ak-fix-low-level-camera-example

Conversation

@ank27
Copy link
Copy Markdown
Contributor

@ank27 ank27 commented Jun 30, 2022

Summary of changes

After #1448 , Low-level camera animation example doesn't have focus over specific lat,lng, thus animations were executed over Point(0.0,0.0). (reported by rave testing team)
This pr revert camera target over New york in order to align with older version and ios.

Also set camera before style loading in globe example better aligning with gl-js.

User impact (optional)

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Optimize code for java consumption (@JvmOverloads, @file:JvmName, etc).
  • Add example if relevant.
  • Document any changes to public APIs.
  • Run make update-api to update generated api files, if there's public API changes, otherwise the verify-api-* CI steps might fail.
  • Update CHANGELOG.md or use the label 'skip changelog', otherwise check changelog CI step will fail.
  • If this PR is a v10.[version] release branch fix / enhancement, merge it to main firstly and then port to v10.[version] release branch.

Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

PRs must be submitted under the terms of our Contributor License Agreement CLA.

@ank27 ank27 requested a review from a team as a code owner June 30, 2022 07:50
@ank27 ank27 self-assigned this Jun 30, 2022
@kiryldz kiryldz changed the title [example] fix low level camera animation example [example] Fix low level camera animation and basic globe example Jun 30, 2022
@ank27 ank27 merged commit 88d1639 into main Jun 30, 2022
@ank27 ank27 deleted the ak-fix-low-level-camera-example branch June 30, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants