Merged
Conversation
Contributor
|
Can we also add command to fetch model list so we know availability of devices. i.e. add |
ank27
approved these changes
Jun 30, 2022
kiryldz
reviewed
Jun 30, 2022
Contributor
kiryldz
left a comment
There was a problem hiding this comment.
just an idea - perhaps simply leave following devices to save costs (and also assuming that robo tests did not catch anything useful for quite a time already):
- api 23 - differs from APIs above in terms for at least Android animators
- pixel 3, api 30 - assuming it's x86 to validate no issues there
- api 31, pretty fresh one
Other 2 devices are a bit questionable for me but in general LGTM to leave them as well
yunikkk
reviewed
Jun 30, 2022
Chaoba
approved these changes
Jun 30, 2022
kiryldz
approved these changes
Jun 30, 2022
yunikkk
approved these changes
Jun 30, 2022
alexander-kulikovskii
approved these changes
Jun 30, 2022
Member
Author
|
The reason behind the virtual device failure is that there’s an ongoing incident on Firebase test lab: I've changed the virtual device to Pixel 2 at API level 29 to avoid the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Update to use the following robo test devices to run robo tests:
User impact (optional)
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).make update-apito update generated api files, if there's public API changes, otherwise theverify-api-*CI steps might fail.check changelogCI step will fail.v10.[version]release branch fix / enhancement, merge it tomainfirstly and then port tov10.[version]release branch.Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
PRs must be submitted under the terms of our Contributor License Agreement CLA.