Skip to content

Apply annotation manager properties to drag layer#640

Merged
Chaoba merged 1 commit intomainfrom
kl-drag-layer-properties
Sep 16, 2021
Merged

Apply annotation manager properties to drag layer#640
Chaoba merged 1 commit intomainfrom
kl-drag-layer-properties

Conversation

@Chaoba
Copy link
Copy Markdown
Contributor

@Chaoba Chaoba commented Sep 14, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Apply annotation manager properties to drag layer to keep annotations the same while dragging</changelog>.

Summary of changes

In the past, we haven't applied the properties to drag layer, so when dragging an annotation, the properties like test font will not keep the same as the original.
This pr applies all the properties to the drag layer to keep annotations the same while dragging.

User impact (optional)

@Chaoba Chaoba added the bug 🪲 Something isn't working label Sep 14, 2021
@Chaoba Chaoba requested a review from a team September 14, 2021 07:05
@Chaoba Chaoba self-assigned this Sep 14, 2021
Copy link
Copy Markdown
Member

@pengdev pengdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Chaoba Chaoba merged commit 47afe98 into main Sep 16, 2021
@Chaoba Chaoba deleted the kl-drag-layer-properties branch September 16, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants