Skip to content

[deps] Bump gl-native to 10.0.0-rc.9, common to 19.0.0.#646

Merged
pengdev merged 2 commits intomainfrom
peng-bump-rc.9
Sep 20, 2021
Merged

[deps] Bump gl-native to 10.0.0-rc.9, common to 19.0.0.#646
pengdev merged 2 commits intomainfrom
peng-bump-rc.9

Conversation

@pengdev
Copy link
Copy Markdown
Member

@pengdev pengdev commented Sep 16, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Bump gl-native to 10.0.0-rc.9, common to 19.0.0. </changelog>.

Summary of changes

This PR bumps the gl-native dependency to 10.0.0-rc.9, common to 19.0.0.

Features ✨ and improvements 🏁

  • Enable instant transitions for data driven symbol layer properties

Bug fixes 🐞

  • Fix transition between layers with all constant properties
  • Fix rendering artifact for a line layer, when its line-gradient property is set at runtime.
  • Don't draw SDF images in text-field and issue warning for it
  • Fix incorrect return from StyleManager#getStyleLayerPropertyDefaultValue for 'text-field', now the default value is set to ["format", "" , {}]

User impact (optional)

@pengdev pengdev added the dependencies Pull requests that update a dependency file label Sep 16, 2021
@pengdev pengdev self-assigned this Sep 16, 2021
@pengdev pengdev changed the title Peng bump rc.9 [deps] Bump gl-native to 10.0.0-rc.9, common to 19.0.0. Sep 16, 2021
Copy link
Copy Markdown
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pengdev several q:

  1. Fix incorrect return from StyleManager#getStyleLayerPropertyDefaultValue for 'text-field', now the default value is set to ["format", "" , {}] - any actions required from our side?
  2. Could we please also add public changelog about common sdk bump

@pengdev pengdev force-pushed the peng-bump-rc.9 branch 2 times, most recently from 92155f4 to 9954fb7 Compare September 20, 2021 14:46
@pengdev pengdev requested a review from a team September 20, 2021 15:24
Copy link
Copy Markdown
Contributor

@kiryldz kiryldz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add public entries from common changelog as well

@pengdev
Copy link
Copy Markdown
Member Author

pengdev commented Sep 20, 2021

LGTM, please add public entries from common changelog as well

I didn't find relevant public change logs from common, but feel free to take another look if you have time.

@pengdev pengdev merged commit bbb10a2 into main Sep 20, 2021
@pengdev pengdev deleted the peng-bump-rc.9 branch September 20, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants