Skip to content

Enable annotations to set null value to nullable properties.#650

Merged
pengdev merged 2 commits intomainfrom
kl-annotation-properties
Sep 21, 2021
Merged

Enable annotations to set null value to nullable properties.#650
pengdev merged 2 commits intomainfrom
kl-annotation-properties

Conversation

@Chaoba
Copy link
Copy Markdown
Contributor

@Chaoba Chaoba commented Sep 17, 2021

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Enable annotations to set null value to nullable properties.</changelog>.

Summary of changes

In the past, we ignore null values while users set them to annotation nullable properties so that users are not able to remove previously set properties.
In this pr, the properties will be removed from annotation if users set null value.

User impact (optional)

@Chaoba Chaoba added the bug 🪲 Something isn't working label Sep 17, 2021
@Chaoba Chaoba self-assigned this Sep 17, 2021
@Chaoba Chaoba requested a review from a team September 17, 2021 10:41
@ank27 ank27 self-requested a review September 21, 2021 08:22
@pengdev pengdev merged commit a3a3768 into main Sep 21, 2021
@pengdev pengdev deleted the kl-annotation-properties branch September 21, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🪲 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants