Conversation
e9b728d to
f6e4fc5
Compare
fcf4846 to
85a602d
Compare
|
@mapbox/maps-android how can we make sure we did not miss anything as part of this PR? any ideas? |
|
Maybe we can use list of possible constructors and call them in a loop? |
We can't 100% make sure this pr covers all the places, but we can keep it in mind and continue iterating on this point if encounter the method need add
Not only constructors, other APIs that have default param need add this annotation too. |
I think we do have an API checker, will it print these info? cc @Chaoba |
That's for checking API change, doesn't have such infos. |
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Add @JvmOverloads where applicable to provide better experience for Java users.</changelog>.Summary of changes
Modify SDK functions where applicable to make Java consumption much more easy and convenient.
Exact steps that were done:
@JvmOverloadsto constructors and methods that have default Kotlin parametersMapboxMap#loadStyleUri,MapboxMap#loadStyleJson,MapboxMap#loadStyleUser impact (optional)