Conversation
tobrun
approved these changes
Sep 22, 2021
alexander-kulikovskii
approved these changes
Sep 22, 2021
pengdev
approved these changes
Sep 22, 2021
ef1594d to
74db03a
Compare
74db03a to
f12ae7e
Compare
Chaoba
reviewed
Sep 22, 2021
d0cd6e3 to
0059742
Compare
axti
reviewed
Sep 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Fix memory leak in renderer destroy.</changelog>.Summary of changes
Fix memory leak in renderer destroy.
Previously in surface mode we did not call releasing native renderer as
Activity.onDestroycall is happening after Android system was sendingSurfaceHolder.Callback.surfaceDestroyedwhen we have already stopped render thread.Diagram from the profiler after the fix and several opening / closing activity with
MapViewUser impact (optional)