Skip to content

3D globe#667

Merged
kiryldz merged 4 commits intomainfrom
kdz-globe-testing
Oct 1, 2021
Merged

3D globe#667
kiryldz merged 4 commits intomainfrom
kdz-globe-testing

Conversation

@kiryldz
Copy link
Copy Markdown
Contributor

@kiryldz kiryldz commented Sep 23, 2021 •
edited
Loading

PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add example if relevant.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Add an entry inside this element for inclusion in the mapbox-maps-android changelog: <changelog>Introduce 3D globe feature.</changelog>.

Summary of changes

This PR introduces 3D globe feature including:

  • exposing convenient API to enable / disable 3D globe view
  • add showcase example activity
device-2021-09-30-124710.mp4

User impact (optional)

@kiryldz kiryldz self-assigned this Sep 23, 2021
@Chaoba
Copy link
Copy Markdown
Contributor

Chaoba commented Sep 23, 2021

Can you add a screen recording for the example?

pengdev
pengdev reviewed Sep 23, 2021
View reviewed changes
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt Outdated
alexander-kulikovskii
alexander-kulikovskii reviewed Sep 27, 2021
View reviewed changes
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt
Comment thread sdk/src/main/java/com/mapbox/maps/MapProjectionUtils.kt
Comment thread sdk/src/main/java/com/mapbox/maps/MapboxMap.kt
Comment thread sdk/src/main/java/com/mapbox/maps/MapboxMap.kt
Comment thread sdk/src/test/java/com/mapbox/maps/MapboxMapTest.kt Outdated
Comment thread sdk/src/test/java/com/mapbox/maps/MapboxMapTest.kt
Comment thread sdk/src/test/java/com/mapbox/maps/MapboxMapTest.kt
alexshalamov
alexshalamov reviewed Sep 28, 2021
View reviewed changes
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt Outdated
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt Outdated
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt
mpulkki-mapbox
mpulkki-mapbox reviewed Sep 28, 2021
View reviewed changes
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt Outdated
@kiryldz kiryldz force-pushed the kdz-globe-testing branch 2 times, most recently from 9d3bda6 to 8ba8144 Compare September 29, 2021 07:50
axti
axti reviewed Sep 29, 2021
View reviewed changes
Comment thread sdk/src/androidTest/java/com/mapbox/maps/GlobeIntegrationTest.kt
axti
axti reviewed Sep 29, 2021
View reviewed changes
Comment thread sdk/src/main/java/com/mapbox/maps/MapProjectionUtils.kt
axti
axti reviewed Sep 29, 2021
View reviewed changes
Comment thread sdk/src/main/java/com/mapbox/maps/NativeMapImpl.kt Outdated
@kiryldz kiryldz mentioned this pull request Sep 30, 2021
Merged
8 tasks
@kiryldz kiryldz requested a review from axti September 30, 2021 09:43
@kiryldz kiryldz marked this pull request as ready for review September 30, 2021 09:49
@kiryldz kiryldz requested a review from a team as a code owner September 30, 2021 09:49
pengdev
pengdev reviewed Sep 30, 2021
View reviewed changes
Comment thread app/src/main/java/com/mapbox/maps/testapp/examples/GlobeActivity.kt Outdated
pengdev
pengdev reviewed Sep 30, 2021
View reviewed changes
Comment thread app/src/main/java/com/mapbox/maps/testapp/examples/GlobeActivity.kt
pengdev
pengdev reviewed Sep 30, 2021
View reviewed changes
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt Outdated
pengdev
pengdev reviewed Sep 30, 2021
View reviewed changes
Comment thread sdk-base/src/main/java/com/mapbox/maps/plugin/MapProjection.kt Outdated
tobrun
tobrun approved these changes Oct 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@kiryldz kiryldz merged commit 4b5a90d into main Oct 1, 2021
@kiryldz kiryldz deleted the kdz-globe-testing branch October 1, 2021 08:58
@endanke endanke mentioned this pull request Oct 4, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobrun tobrun tobrun approved these changes

@pengdev pengdev pengdev approved these changes

@alexshalamov alexshalamov Awaiting requested review from alexshalamov

@alexander-kulikovskii alexander-kulikovskii Awaiting requested review from alexander-kulikovskii

@mpulkki-mapbox mpulkki-mapbox Awaiting requested review from mpulkki-mapbox

+1 more reviewer

@axti axti axti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kiryldz kiryldz

Labels

feature 🍏

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kiryldz @Chaoba @alexshalamov @tobrun @pengdev @alexander-kulikovskii @axti @mpulkki-mapbox