Throw exception when camera plugin is missing#668
Merged
Conversation
Chaoba
approved these changes
Sep 23, 2021
Contributor
Chaoba
left a comment
Chaoba
left a comment
There was a problem hiding this comment.
You need to update the PR title.
Contributor
|
@axti please make PR name shorter (it does not even fit) and go thru checkpoints in the PR |
pengdev
approved these changes
Sep 23, 2021
ank27
approved these changes
Sep 23, 2021
axti
changed the title
kiryldz
approved these changes
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Throw exception when camera plugin was not created and used camera functionality</changelog>.Summary of changes
Exception will be thrown when camera functionality trying to use but plugin was not added to MapView. Reported in #1118
User impact (optional)