[gestures] Refactor gestures configuration options to be aligned better across platforms.#672
[gestures] Refactor gestures configuration options to be aligned better across platforms.#672
Conversation
c04ba8b to
0baf65c
Compare
fb53430 to
f5e9d12
Compare
848cd47 to
7d2ef39
Compare
c18e57e to
208d6bb
Compare
208d6bb to
c3a6fd7
Compare
ac9ac9e to
02bb780
Compare
|
Hey folks, just FYI but this is breaking the Maps SDK v10's public API your users are working with. I just upgraded to v10.2.0 and ran into my code base no longer compiling https://github.com/mapbox/mapbox-maps-android/releases/tag/android-v10.2.0 It would have been great to call it out in the changelog or release notes. Are breaking changes expected between minor version changes, because you folks want to keep the major version at v10? |
|
Hi @daniel-j-h , sorry to hear this breaks your codebase. |
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-androidchangelog:<changelog>Refactor gestures configuration options to be aligned better across platforms.</changelog>.Summary of changes
This PR refactors the gestures plugin's configuration options to be better aligned with iOS SDK.
List of changes:
flingVelocityAnimationEnabledtoscrollDecelerationEnabledrotateVelocityAnimationEnabledtorotateDecelerationEnabledscaleVelocityAnimationEnabledtopinchToZoomDecelerationEnabledzoomEnabledtopinchToZoomEnabledand limit its effect to just pinch to zoompanScrollModetoscrollModezoomRatetozoomAnimationAmountdisableRotateWhenScalingincreaseRotateThresholdWhenScalingtoincreaseRotateThresholdWhenPinchingToZoomincreaseScaleThresholdWhenRotatingtoincreasePinchToZoomThresholdWhenRotatingdoubleTapToZoomEnabledintodoubleTapToZoomInEnabledanddoubleTouchToZoomOutEnabledpixelRatiofrom gesture options (if needed, use the value from map init options so that this option is not duplicated)GesturesSettings#isPanHorizontallyLimitedtoGesturesSettings#isScrollHorizontallyLimitedGesturesSettings#isPanVerticallyLimitedtoGesturesSettings#isScrollVerticallyLimited