Merged
Conversation
5730994 to
cbee69b
Compare
tobrun
approved these changes
Oct 1, 2021
alexander-kulikovskii
approved these changes
Oct 1, 2021
ank27
reviewed
Oct 1, 2021
ank27
reviewed
Oct 1, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
@JvmOverloads,@file:JvmName, etc).mapbox-maps-androidchangelog:<changelog>Applying geojson data (using data, url, feature, featureCollection, geometry functions) is fully async now.</changelog>.Summary of changes
Synchronous API for parsing
feature,featureCollection,geometryon UI thread was removed.Now when passing any kind of data to geojson source with
data,url,feature,featureCollection,geometry- this will get scheduled on a worker thread, parsed, passed to core, processed in core on a worker thread and finally applied to the map.User impact (optional)
Following APIs are impacted:
GeoJsonSource.data(userData)is also setting data using worker thread meaning that if somefeatureCollectionis already parsing - it will be parsed till end, applied to the map and replaced immediately byuserData.GeoJsonSource.url(userUrl)is also setting data using worker thread meaning that if somefeatureCollectionis already parsing - it will be parsed till end, applied to the map and replaced immediately byuserUrl.