Skip to content

prepare release v2.19.0-beta.1#1099

Merged
maios merged 4 commits intomainfrom
prepare-v2.19.0-beta.1
Jan 29, 2026
Merged

prepare release v2.19.0-beta.1#1099
maios merged 4 commits intomainfrom
prepare-v2.19.0-beta.1

Conversation

@maios
Copy link
Copy Markdown
Contributor

@maios maios commented Jan 29, 2026

No description provided.

@maios maios requested a review from a team as a code owner January 29, 2026 09:56
@maios maios requested a review from pjleonard37 January 29, 2026 09:56
evil159
evil159 previously approved these changes Jan 29, 2026
});

testWidgets('StyleUpdateJSON', (WidgetTester tester) async {
testWidgets('StyleUpdateURI', (WidgetTester tester) async {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new name?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is duplicated with

testWidgets('StyleUpdateJSON', (WidgetTester tester) async {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird 🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the first test is adding style import with style uri, and update with json. the 2nd test (the one that is failing) is adding style import with json, and update with style uri, that's why I am changing the name to avoid confusion

@maios maios requested review from evil159 and pjleonard37 January 29, 2026 13:09
@maios maios enabled auto-merge (squash) January 29, 2026 13:21
@maios maios merged commit baef3e7 into main Jan 29, 2026
7 checks passed
@maios maios deleted the prepare-v2.19.0-beta.1 branch January 29, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants