Open
Conversation
|
|
Author
|
@mapbox/mapbox-maps-flutter - @evil159 - Any thoughts here? |
Contributor
|
Hi @dballance -- Thanks for the PR! We'll take a look early next week. 😀 |
Author
|
Great - thanks - happy to rework or extend if needed! |
# Conflicts: # CHANGELOG.md # ios/mapbox_maps_flutter/Sources/mapbox_maps_flutter/Classes/MapboxMapController.swift # lib/src/mapbox_map.dart
dballance
force-pushed
the
feat/add-http-interceptor-support
branch
from
4015162 to
2849f76
Compare
Contributor
|
Hi @dballance -- A few things came up earlier this week, but this is first on my to do list tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds HTTP interceptor support, in Dart, to match up to the native SDK functionality.
The interceptors are added before a map is instantiated, so that all requests (including fonts, images, etc) can be modified / logged / observed when the map is created. All map instances will share the same interceptor, much like the existing SDK functionality.
I'm opening this first to get feedback on the overall approach - will add tests if needed. Seems most of the native code is only tested indirectly, so would potentially just be an integration test of some sort.
What is the motivation and context behind this change?
Allow per request header modifications, logging, and tracing spans on map requests. Would potentially close #1062 and other stories.
Pull request checklist:
PRs must be submitted under the terms of our Contributor License Agreement CLA.