Skip to content

Conversation

@evil159
Copy link
Contributor

@evil159 evil159 commented Dec 4, 2024

What does this pull request do?

Fixes buffer underflow exception when trying to get style image added programmatically on Android.

What is the motivation and context behind this change?

Pull request checklist:

  • Add a changelog entry.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.

@evil159 evil159 requested a review from a team as a code owner December 4, 2024 13:15
@evil159 evil159 requested a review from pjleonard37 December 4, 2024 13:15
@pjleonard37 pjleonard37 merged commit 0de68d6 into pjl/update-versions-2.5.0-beta.1 Dec 4, 2024
5 of 6 checks passed
@pjleonard37 pjleonard37 deleted the rl/fix_image_buffer_underflow_exeption_android branch December 4, 2024 13:24
pjleonard37 added a commit that referenced this pull request Dec 4, 2024
* Update versions

* Change symbol-elevation-reference from paint to layout property

* Update versions

* Revert "Remove secret token requirement from Android side (#789)"

This reverts commit 73e9719.

* Update event listeners on initState

* Fix image underflow exception on android (#797)

* Revert "Revert "Remove secret token requirement from Android side (#789)""

This reverts commit 71e9b2a.

---------

Co-authored-by: Release SDK bot for Maps SDK team <maps_sdk_ios@mapbox.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
brandon-watkins-avcrm pushed a commit to brandon-watkins-avcrm/mapbox-maps-flutter that referenced this pull request Mar 27, 2025
* Update versions

* Change symbol-elevation-reference from paint to layout property

* Update versions

* Revert "Remove secret token requirement from Android side (mapbox#789)"

This reverts commit 73e9719.

* Update event listeners on initState

* Fix image underflow exception on android (mapbox#797)

* Revert "Revert "Remove secret token requirement from Android side (mapbox#789)""

This reverts commit 71e9b2a.

---------

Co-authored-by: Release SDK bot for Maps SDK team <maps_sdk_ios@mapbox.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants