Skip to content

Conversation

@shinriyo
Copy link
Contributor

it is not nullable
and it is Point object

What does this pull request do?

fix old one

What is the motivation and context behind this change?

I want good README

Pull request checklist:

  • Add a changelog entry.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.

@shinriyo shinriyo requested a review from a team as a code owner January 21, 2025 06:28
@shinriyo shinriyo requested a review from evil159 January 21, 2025 06:28
Copy link
Contributor

@pjleonard37 pjleonard37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these edits!

it is not nullable
and it is Point object
@pjleonard37 pjleonard37 changed the base branch from main to public/shinriyo-patch1 January 22, 2025 13:54
@pjleonard37 pjleonard37 merged commit 2f87610 into mapbox:public/shinriyo-patch1 Jan 22, 2025
pjleonard37 added a commit that referenced this pull request Jan 22, 2025
it is not nullable
and it is Point object

Co-authored-by: shinriyo <shinriyo@gmail.com>
evil159 added a commit that referenced this pull request Feb 3, 2025
* Update README.md for viewport support (#841)

* Update README.md (#837) (#842)

it is not nullable
and it is Point object

Co-authored-by: shinriyo <shinriyo@gmail.com>

* Align tap propagation behavior on Android and iOS. (#847)

* Introduce Interactions API (#748)

* Initial implementation of QRF and Featurestate

* Add Standard experimental, build out Android

* Finish up Android interfaces, general cleanup

* Linting updates

* Additional lint edits

* Clean up type conversions, restore tests

* Update for linting

* Change toValue back

* Update example, some docs cleanup

* Revert

* Build out geometries

* Address review feedback

* Add framework for typed interactions

* Update generated code

* Add map.addInteraction, add Standard featuresets

* Update for sanity check

* Remove viewport query, general cleanup

* Update viewport QRF implementation

* Remove FeaturesetQueryTarget, minor updates from review

* Update Android interface, some formatting

* Make Interactions internal, update implementation

* Initial generics implementation

* Update Podfile

* Update to move _Interactions internal

* Update error handling and interfaces

* Update for lint

* Move interaction to pigeon generation

* Expand use of generics, rename

---------

Co-authored-by: Release SDK bot for Maps SDK team <maps_sdk_ios@mapbox.com>

* Bump platform SDKs version (#855)

* Bump SDK version to 2.6.0-rc.1 (#856)

---------

Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
Co-authored-by: shinriyo <shinriyo@gmail.com>
Co-authored-by: Release SDK bot for Maps SDK team <maps_sdk_ios@mapbox.com>
brandon-watkins-avcrm pushed a commit to brandon-watkins-avcrm/mapbox-maps-flutter that referenced this pull request Mar 27, 2025
it is not nullable
and it is Point object

Co-authored-by: shinriyo <shinriyo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants