Added an isochrone example.#211
Merged
cafesilencio merged 1 commit intomainfrom Oct 23, 2024
Merged
Conversation
cafesilencio
force-pushed
the
sb-NAVAND-3735-isochrone-example
branch
from
230fd8a to
8c2c4fb
Compare
kmadsen
reviewed
Oct 23, 2024
Comment on lines
+41
to
+43
| private val mapboxMap: MapboxMap by lazy { | ||
| binding.mapView.getMapboxMap() | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| private val mapboxMap: MapboxMap by lazy { | |
| binding.mapView.getMapboxMap() | |
| } | |
| private var mapboxMap: MapboxMap? = null |
onDestroy should still null out this object. "loadStyle" is technically async and could return after the Activity is destroyed.
kmadsen
reviewed
Oct 23, 2024
| } | ||
|
|
||
| val cameraOptions = CameraOptions.Builder().center(Point.fromLngLat(-73.990593, 40.740121)).zoom(12.0).build() | ||
| binding.mapView.getMapboxMap().setCamera(cameraOptions) |
Contributor
There was a problem hiding this comment.
Suggested change
| binding.mapView.getMapboxMap().setCamera(cameraOptions) | |
| mapboxMap?.setCamera(cameraOptions) |
Contributor
There was a problem hiding this comment.
maybe the MapView lifecycle handles this case though and it's not really a problem.
kmadsen
approved these changes
Oct 23, 2024
cafesilencio
force-pushed
the
sb-NAVAND-3735-isochrone-example
branch
from
8c2c4fb to
1b7a3f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an example demonstrating the use of the isochrone API.