Increment leg index upon way point arrival#1604
Merged
Merged
Conversation
danesfeder
requested review from
Guardiola31337,
devotaaabel and
kevinkreiser
kevinkreiser
approved these changes
Dec 5, 2018
Codecov Report
@@ Coverage Diff @@
## master #1604 +/- ##
============================================
+ Coverage 22.56% 22.65% +0.09%
- Complexity 694 700 +6
============================================
Files 189 189
Lines 8230 8241 +11
Branches 606 609 +3
============================================
+ Hits 1857 1867 +10
- Misses 6190 6191 +1
Partials 183 183 |
This was referenced Dec 5, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1487
We currently do not increment the
RouteLegupon arrival of each way point along the route. This essentially means we can only navigate from an origin to a destination with way points in between.This PR looks at a few criteria before incrementing the index and reseting the
NavigationStatuswith the new data.