Add check to only cache instructions if the language setup is supported by Voice API#1610
Merged
Merged
Conversation
danesfeder
approved these changes
Dec 6, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks @Guardiola31337 one minor comment!
| this.cache = cache; | ||
| } | ||
|
|
||
| VoiceInstructionLoader(Context context, String accessToken, Cache cache, MapboxSpeech.Builder mapboxSpeechBuilder) { |
Contributor
There was a problem hiding this comment.
NIT can we comment this as only for testing?
danesfeder
approved these changes
Dec 6, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks @Guardiola31337 one minor comment!
Guardiola31337
force-pushed
the
pg-1608-voice-instruction-ukrainian-issue
branch
from
75f047e to
ef0ae5f
Compare
Guardiola31337
force-pushed
the
pg-1608-voice-instruction-ukrainian-issue
branch
from
ef0ae5f to
1e1b15e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
============================================
+ Coverage 22.65% 22.76% +0.11%
- Complexity 700 704 +4
============================================
Files 189 189
Lines 8241 8244 +3
Branches 609 609
============================================
+ Hits 1867 1877 +10
+ Misses 6191 6184 -7
Partials 183 183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1608