Move SummaryBottomSheet above RecenterBtn in navigation_view_layout.xml#1616
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
=========================================
Coverage 22.76% 22.76%
Complexity 704 704
=========================================
Files 189 189
Lines 8244 8244
Branches 609 609
=========================================
Hits 1877 1877
Misses 6184 6184
Partials 183 183 |
Guardiola31337
approved these changes
Dec 7, 2018
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Looks good to me @danesfeder
danesfeder
force-pushed
the
dan-update-xml
branch
from
1c19b4b to
de5f8e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure why this reproducible consistently, but I think #1614 and #1424 (comment) are valid.
It seems this error can occur when a view in the XML is trying to anchor to another view that hasn't been declared yet in the XML. In our case, the
RecenterBtnwas trying to anchor to theSummaryBottomSheetdirectly below it. See https://stackoverflow.com/a/11669528/8412108