Fix turn-by-turn UI voice instructions repeated after a config change#1622
Merged
Conversation
Guardiola31337
force-pushed
the
pg-route-update-turn-by-turn-ui
branch
from
7af0050 to
6a087a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1622 +/- ##
============================================
+ Coverage 23.58% 23.71% +0.13%
- Complexity 728 735 +7
============================================
Files 193 194 +1
Lines 8276 8281 +5
Branches 609 608 -1
============================================
+ Hits 1952 1964 +12
+ Misses 6139 6132 -7
Partials 185 185 |
danesfeder
approved these changes
Dec 12, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
@Guardiola31337 thanks for the refactoring and tests here! ✅
…led only if navigation is not running (first time / once) or if it is off route - preventing setting new routes unnecessarily which ended up in announcing voice instructions already announced
Guardiola31337
force-pushed
the
pg-route-update-turn-by-turn-ui
branch
from
6a087a4 to
7bf9017
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updateRoutein turn-by-turn UI (NavigationViewModel) to be called only if navigation is not running (first time / once) or if it is off route - preventing setting new routes unnecessarily which ended up in announcing voice instructions already announced