Include 'exit roundabout' in Navigation Constants#1628
Merged
Conversation
|
Looks like I forgot an import. |
Update maneuver types based on latest values and order documented
Contributor
Author
|
@brentnd |
Guardiola31337
force-pushed
the
brentnd-exit-roundabout
branch
from
dd72b2a to
d193c2b
Compare
|
Thanks @Guardiola31337. Sorry I missed that. |
Codecov Report
@@ Coverage Diff @@
## master #1628 +/- ##
============================================
- Coverage 23.7% 23.68% -0.02%
Complexity 735 735
============================================
Files 194 194
Lines 8285 8291 +6
Branches 608 608
============================================
Hits 1964 1964
- Misses 6136 6142 +6
Partials 185 185 |
danesfeder
approved these changes
Dec 13, 2018
Contributor
danesfeder
left a comment
danesfeder
left a comment
There was a problem hiding this comment.
Thanks for the find here @brentnd 👍and pulling the code in for CI @Guardiola31337
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #1626
@brentnd thanks again for the contribution. I pulled in your commit here so CI runs and we will get final 👀 from the rest of the team.