Fix flaky instrumentation tests (#4726)#4931
Merged
Guardiola31337 merged 1 commit intorelease-v2.0from Oct 1, 2021
Merged
Conversation
- pull / push history files from device to gcloud test bucket - use mapbox history test rule and set /sdcard/Download/mapbox_test as directory to pull from - add logs and relaxed expected coordinates - capture exceptions and retrieve history files up to that point - mapbox navigation creation (setup) run on main sync
Guardiola31337
added
skip changelog
RingerJK
reviewed
Oct 1, 2021
| routeOptions: RouteOptions | ||
| ) { | ||
| // no impl | ||
| logE(Tag("DEBUG"), Message("onFailure reasons=$reasons")) |
Contributor
There was a problem hiding this comment.
very interesting Tags in the PR 😄 could you rename them to a specific
Contributor
Author
There was a problem hiding this comment.
This is a 🍒
And it's tests (we can fix in a separate PR if needed) 😅
Contributor
There was a problem hiding this comment.
yeah, I know, but it's still an issue :)
Contributor
Author
There was a problem hiding this comment.
Could you cut a ticket? BTW Using DEBUG in tests is not a problem for me 😬
| } | ||
| countDownLatch.await() | ||
| } | ||
| throw t |
Contributor
There was a problem hiding this comment.
throw can happen before runOnMainSync finished
Contributor
Author
There was a problem hiding this comment.
Should be executed synchronously 🤔
In any case, is that a problem? As long as it gets executed we should be good.
RingerJK
approved these changes
Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CP #4726
Fix flaky instrumentation tests