MapboxCarMapSurface observe map style

[korshaknn]

Description

observe map style when MapboxCarMapSurface is attached

Screenshots or Gifs

[codecov]

Codecov Report

Merging #5853 (ed945e3) into main (77ca26c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ed945e3 differs from pull request most recent head a7035c8. Consider uploading reports for the commit a7035c8 to get more accurate results

@@            Coverage Diff             @@
##               main    #5853    +/-   ##
==========================================
  Coverage     67.55%   67.56%            
+ Complexity     3877     3834    -43     
==========================================
  Files           591      586     -5     
  Lines         23844    23621   -223     
  Branches       2747     2725    -22     
==========================================
- Hits          16108    15959   -149     
+ Misses         6709     6644    -65     
+ Partials       1027     1018     -9     

Impacted Files	Coverage Δ
...gation/core/routerefresh/RouteRefreshController.kt	93.22% <0.00%> (-1.47%)	⬇️
...ava/com/mapbox/navigation/core/MapboxNavigation.kt	62.92% <0.00%> (-0.66%)	⬇️
...n/ui/maps/route/line/model/RouteLineDynamicData.kt	53.65% <0.00%> (-0.35%)	⬇️
...tion/ui/maps/route/line/api/MapboxRouteLineView.kt	95.91% <0.00%> (-0.07%)	⬇️
...ation/ui/maps/route/line/api/MapboxRouteLineApi.kt	81.05% <0.00%> (-0.06%)	⬇️
...ava/com/mapbox/navigation/dropin/NavigationView.kt	0.00% <0.00%> (ø)
...navigation/dropin/internal/extensions/ContextEx.kt	0.00% <0.00%> (ø)
...ils/internal/datastore/NavigationDataStoreOwner.kt
.../ui/voice/internal/impl/MapboxAudioGuidanceImpl.kt
...on/ui/maps/route/line/model/RouteLineTrimOffset.kt
... and 15 more

[yunikkk]

What if style is updated without detach - won't you try to add persistent style several times?

[kmadsen]

is it an issue to add a persistent style custom layer multiple times?

another note is that, we want to delete this class and adopt the new map widgets #5793.

The solution here will be temporary, but the solution would translate to other persistent styles

[korshaknn]

added a flag

[yunikkk]

It won't crash but will return Expected.error from
Expected<String, com.mapbox.bindgen.None> addPersistentStyleCustomLayer(@NonNull String layerId, @NonNull CustomLayerHost layerHost, @Nullable LayerPosition layerPosition);.
It's not a big issue but I assume still better to fix to avoid possible issues.

[korshaknn]

@kmadsen btw, do we really need to observe style changes? can it be changed somehow at runtime? do we have any usecases?

it can't be added if we observe style dynamically depending on a head uint / phone settings

cc @Zayankovsky

[Guardiola31337]

Noting that ktlint is failing 👀

> Task :libnavui-androidauto:ktlint
/root/code/libnavui-androidauto/src/main/java/com/******/androidauto/car/navigation/roadlabel/RoadLabelSurfaceLayer.kt:19:1: Unused import (no-unused-imports)

> Task :libnavui-androidauto:ktlint FAILED

FAILURE: Build failed with an exception.

[korshaknn]

@kmadsen any concerns here?

[kmadsen]

This is quite nice. Nice work!

Thinking about this more, and I think we can move it up to the maps-androidauto extension
https://github.com/mapbox/mapbox-maps-android/tree/main/extension-androidauto

Happy to merge this here, and then we can propose it to maps. And eventually delete it from here

[kmadsen]

The current road label is not changing when updating map styles (switch from day/night)

You can test day and night changes like this. This triggers a style change and anything designed to update day/night should update their color. Some components manage it internally (location puck for example, is updated internally.. but the night color is only in 1tap not in the sdk)

➜ mapbox-navigation-android git:(knn_observe_style) make car

day
night
day

Actual	Expected

[kmadsen]

The current road label is not showing up on the MainCarScreen anymore 🤔

[kmadsen]

This class does not do anything when the style changes. So let's use the getStyle extension here and remove the styleLoadedListener handle and persistentStyleAdded flag

Suggested change

	styleLoadedListener = mapboxCarMapSurface.handleStyleOnAttached {
	mapboxCarMapSurface.getStyle {

[korshaknn]

can't use a sync getStyle extension, because style might be null when onAttached is called, so added a new
getStyleAsync extension

[kmadsen]

Just pulled the branch and the day/night style is no longer updating

[korshaknn]

Just pulled the branch and the day/night style is no longer updating

@kmadsen I've tested this commands on 1Tap and they do nothing (tested with AA 0.2.0 and AA with current PR changes)
@Zayankovsky also tested it and had the same results

but style change works with AndroidAuto app settings, so I change it on my phone:

Screen.Recording.2022-06-07.at.12.31.30.online-video-cutter.com.mp4

[kmadsen]

Nice work! Video looks great #5853 (comment)