Skip to content

add an option to override route options used by android auto#6153

Merged
Zayankovsky merged 2 commits intomainfrom
vz-route-options-interceptor
Aug 11, 2022
Merged

add an option to override route options used by android auto#6153
Zayankovsky merged 2 commits intomainfrom
vz-route-options-interceptor

Conversation

@Zayankovsky
Copy link
Copy Markdown
Contributor

@Zayankovsky Zayankovsky commented Aug 11, 2022

Description

Removed routeAlternativesEnabled flow in MainCarContext in favor of a more flexible CarRouteOptionsInterceptor that allows you to override any route options. This can be used to enable/disable alternatives. Also fixed an issue with alternative route line not vanishing.

@Zayankovsky Zayankovsky added the Android Auto Bugs, improvements and feature requests on Android Auto. label Aug 11, 2022
@Zayankovsky Zayankovsky self-assigned this Aug 11, 2022
@Zayankovsky Zayankovsky force-pushed the vz-route-options-interceptor branch 3 times, most recently from c1d91fd to 8209914 Compare August 11, 2022 15:47
@Zayankovsky Zayankovsky marked this pull request as ready for review August 11, 2022 15:47
@Zayankovsky Zayankovsky requested a review from a team as a code owner August 11, 2022 15:47
@Zayankovsky Zayankovsky force-pushed the vz-route-options-interceptor branch from 8209914 to d846908 Compare August 11, 2022 16:09
@Zayankovsky Zayankovsky changed the title added an option to override route options used by android auto add an option to override route options used by android auto Aug 11, 2022
@Zayankovsky Zayankovsky force-pushed the vz-route-options-interceptor branch from d846908 to 9e8d8ba Compare August 11, 2022 16:12
Copy link
Copy Markdown
Contributor

@kmadsen kmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 11, 2022

Codecov Report

Merging #6153 (9e8d8ba) into main (1b19606) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #6153   +/-   ##
=========================================
  Coverage     68.90%   68.90%           
  Complexity     4255     4255           
=========================================
  Files           639      639           
  Lines         25646    25646           
  Branches       3003     3003           
=========================================
  Hits          17671    17671           
  Misses         6828     6828           
  Partials       1147     1147           

@Zayankovsky Zayankovsky merged commit 253b03a into main Aug 11, 2022
@Zayankovsky Zayankovsky deleted the vz-route-options-interceptor branch August 11, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Auto Bugs, improvements and feature requests on Android Auto.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants