[Drop-In UI] Moved CameraModeButtonComponent outside Drop-In UI#6202
Merged
tomaszrybakiewicz merged 4 commits intomainfrom Aug 24, 2022
Merged
[Drop-In UI] Moved CameraModeButtonComponent outside Drop-In UI#6202tomaszrybakiewicz merged 4 commits intomainfrom
tomaszrybakiewicz merged 4 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6202 +/- ##
============================================
- Coverage 68.81% 68.74% -0.07%
- Complexity 4300 4308 +8
============================================
Files 646 649 +3
Lines 25927 26010 +83
Branches 3041 3054 +13
============================================
+ Hits 17841 17881 +40
- Misses 6931 6969 +38
- Partials 1155 1160 +5
|
abhishek1508
approved these changes
Aug 23, 2022
Unit tests for new components. Re-gen libnavui-maps Metalava API file.
5441406 to
847e5b4
Compare
Contributor
Author
|
@abhishek1508 I fixed the |
Contributor
I think it does not like the empty line... Will fix: #6221 |
Contributor
We are seeing similar issues in android-auto and ticket has been created. Let us merge this PR. @tomaszrybakiewicz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/mapbox/navigation-sdks/issues/1780
TL;DR
This PR adds two new ComponentInstallers:
navigationCamera()that simplifies integration ofNavigationCameraandcameraModeButton()that toggles between NavigationCameraState.FOLLOWING and NavigationCameraState.OVERVIEW on button press.Description
CameraModeButtonComponenttolibnavui-mapsmoduleCameraModeButtonComponentfrom theStoreby introducingCameraModeButtonComponentContractCameraModeButtonComponentContractimplementationsNavigationCameraComponentthat simplifiesMapboxNavigationViewportDataSourceandNavigaitonCameraintegrationNavigationCameraGestureComponentthat registersNavigationBasicGesturesHandlerwhen attached (NavigationBasicGesturesHandler updates NavigationCamera to IDLE when map gesture is detected)